Search Mailing List Archives


Limit search to: Subject & Body Subject Author
Sort by: Reverse Sort
Limit to: All This Week Last Week This Month Last Month
Select Date Range     through    

[tcpcrypt-dev] use PACKAGE_VERSION INSTEAD OF TCPCRYPT_VERSION ? [Re: was: [PATCH] report tcpcrypt version 0.2]

Daniel Kahn Gillmor dkg at fifthhorseman.net
Thu Jul 24 05:32:18 PDT 2014


On 07/24/2014 08:25 AM, Daniel Kahn Gillmor wrote:
> ---
>  user/configure    | 20 ++++++++++----------
>  user/configure.ac |  2 +-
>  2 files changed, 11 insertions(+), 11 deletions(-)

This patch fixes the version string in the configuration directives, and
by default exports PACKAGE_VERSION=0.2 to all the build processes we use
on linux.

I think this might remove the need for tcpcrypt_version.h, which means
that you'd only need to keep track of the version number in one place.

That might be a nicesimplification, but i don't know what the
consequences would be for the non-linux builds.  do they need
tcpcrypt_version.h for anything?

I see it in the launchers for mac and windows:

contrib/TcpcryptLauncher/Classes/TcpcryptLauncherAppDelegate.m:    						 TCPCRYPT_VERSION];
contrib/winlauncher/tcpcrypt.c:	snprintf(title, sizeof(title), "tcpcrypt
v%s", TCPCRYPT_VERSION);

But maybe those could use PACKAGE_VERSION instead too?

	--dkg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: OpenPGP digital signature
URL: <http://mailman.stanford.edu/pipermail/tcpcrypt-dev/attachments/20140724/fb82df6e/attachment.asc>


More information about the tcpcrypt-dev mailing list