Search Mailing List Archives


Limit search to: Subject & Body Subject Author
Sort by: Reverse Sort
Limit to: All This Week Last Week This Month Last Month
Select Date Range     through    

[PATCH] Added ability to look up operational attributes

Russ Allbery eagle at windlord.stanford.edu
Fri Apr 5 10:39:39 PDT 2013


William Orr <worr at csh.rit.edu> writes:

> Yes, that is how ldapsearch works, however I modeled my code after
> yours, which seems to dump all of the attributes and then only set the
> ones we're interested in into the environment, as well as the default
> set.

> Because I didn't want to modify the code too heavily, and because I
> didn't want to be responsible for making a list of default variables, I
> opted for this method.

Indeed, I see now.  Thanks for the explanation!  This code is the one bit
of code in WebAuth that I've never really done anything to, so I don't
know it very well, and I was blindly assuming that lc->attrs was actually
set to something useful.  It's not actually set at all (just set to NULL
by calloc)!

I think the way the existing code works badly needs to be fixed, but in
the meantime your code certainly doesn't make things any worse and indeed
it's the way to do it while changing as little as possible.

Applied for the next release.  Thanks!

-- 
Russ Allbery <eagle at windlord.stanford.edu>
Technical Lead, ITS Infrastructure Delivery Group, Stanford University


More information about the webauth-info mailing list